Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initialize argument #23

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Remove initialize argument #23

merged 1 commit into from
Jun 8, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

Small fix to remove unneeded argument
Fixes #22

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Regular CI

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok as well!!!

@codecov-commenter
Copy link

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   20.31%   20.31%           
=======================================
  Files           9        9           
  Lines         507      507           
=======================================
  Hits          103      103           
  Misses        391      391           
  Partials       13       13           
Impacted Files Coverage Δ
server/endpoints.go 60.00% <52.94%> (ø)
server/server.go 20.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455a646...4103d52. Read the comment docs.

@joselsegura joselsegura merged commit ba60450 into RedHatInsights:master Jun 8, 2020
@joselsegura joselsegura deleted the remove_initialize_argument branch September 27, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server.Initialize receive an unnecessary argument
4 participants