Adding rules static content pulling from content-service #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselsegura
requested review from
Bee-lee,
bond95,
natiiix,
quarckster,
Serhii1011010 and
tisnik
as code owners
tisnik
approved these changes
Jun 10, 2020
| github.com/RedHatInsights/insights-operator-utils v1.0.1 h1:uxMsNAMGfhb1ABRXITSHAUnDypceI7eRfLvrwCpq+A4= | ||
| github.com/RedHatInsights/insights-operator-utils v1.0.1/go.mod h1:gRzYBMY4csuOXgrxUuC10WUkz6STOm3mqVsQCb+AGOQ= | ||
| github.com/RedHatInsights/insights-results-aggregator v0.0.0-20200522085341-3cf0c4554206/go.mod h1:7Pc15NYXErx7BMJ4rF1Hacm+29G6atzjhwBpXNFMt+0= | ||
| github.com/RedHatInsights/insights-results-aggregator v0.0.0-20200527194606-78d5e04acbc1 h1:H5KIqvvrrOugAI03zmfTv0I3psuUSuDnsIciU1S38r4= | ||
| github.com/RedHatInsights/insights-results-aggregator v0.0.0-20200527194606-78d5e04acbc1/go.mod h1:7Pc15NYXErx7BMJ4rF1Hacm+29G6atzjhwBpXNFMt+0= | ||
| github.com/RedHatInsights/insights-results-aggregator v0.0.0-20200604090056-3534f6dd9c1c h1:/kb5AwNxizPf+0R4OWWRvWbLqAwf07Bu97R4WVHk2Uw= |
There was a problem hiding this comment.
Usually if you delete this file, it is reconstructed on the next build.
There was a problem hiding this comment.
I will try. I removed with sed lines referring to insights-content-service because it uses and previous version and gob didn't work very well. I will check
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 21.07% 21.62% +0.54%
==========================================
Files 9 9
Lines 541 555 +14
==========================================
+ Hits 114 120 +6
- Misses 413 420 +7
- Partials 14 15 +1
Continue to review full report at Codecov.
|
quarckster
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides the mechanism to get the static content for all the rules from the content-service
Fixes #7
Type of change
Testing steps
Regular CI