Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefile #36

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Improve Makefile #36

merged 1 commit into from
Jun 19, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

Improves on Makefile:

  • Taking advantage of Make file dependency system (only a bit)
  • Adding rules for generating godoc

Fixes #19

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Regular CI

@codecov-commenter
Copy link

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   20.93%   20.93%           
=======================================
  Files          10       10           
  Lines         578      578           
=======================================
  Hits          121      121           
  Misses        442      442           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6b8b0...8a8fe47. Read the comment docs.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar approach as in other repo => quick LGTM!

@joselsegura joselsegura merged commit 0841a78 into RedHatInsights:master Jun 19, 2020
@joselsegura joselsegura deleted the improve_makefile branch June 19, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Makefile
4 participants