Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected response on groups endpoint specification and some tooling #73

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Fix expected response on groups endpoint specification and some tooling #73

merged 2 commits into from
Jun 30, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

OpenAPI spec was outdated and refers to a redirection that is not done. Fixing and adding some tooling to manually check the OpenAPI specification

Fixes #72

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

Regular CI

openapi.json Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   41.95%   41.95%           
=======================================
  Files          12       12           
  Lines         882      882           
=======================================
  Hits          370      370           
  Misses        469      469           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd2001...2d508c5. Read the comment docs.

Copy link
Collaborator

@Bee-lee Bee-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joselsegura joselsegura merged commit 558c44c into RedHatInsights:master Jun 30, 2020
@joselsegura joselsegura deleted the fix_openapi_groups branch September 27, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/groups endpoint has incorrect status code in openapi spec
4 participants