Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-36297 | refactor: handlers' versioning #3128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MikelAlejoBR
Copy link
Member

The goal is to improve readability by providing specific classes for each version of the endpoints that we serve. By having them grouped by class and file, it is easy to check what the V1 or V2 paths have.

Jira ticket

[RHCLOUD-36297]

@g-duval g-duval self-assigned this Nov 26, 2024
Copy link
Contributor

@g-duval g-duval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome, thank you Mikel.
Nevertheless I would split those only for apis requesting a V2, WDYT?

@MikelAlejoBR MikelAlejoBR force-pushed the RHCLOUD-36297-refactor-handlers-versioning branch from c139f89 to 709c429 Compare November 28, 2024 10:36
The goal is to improve readability by providing specific classes for
each version of the endpoints that we serve. By having them grouped by
class and file, it is easy to check what the V1 or V2 paths have.

RHCLOUD-36297
@MikelAlejoBR MikelAlejoBR force-pushed the RHCLOUD-36297-refactor-handlers-versioning branch from 709c429 to 8fff02a Compare November 28, 2024 10:42
Copy link
Contributor

@g-duval g-duval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we also keep only EndpointResourceV2 & NotificationsV2?
Then we could add some *resourceV2 when we will be needed for other APIs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants