Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(RecsList & Single Cluster page): changed the Added column #178

Merged
merged 1 commit into from
Mar 15, 2022
Merged

style(RecsList & Single Cluster page): changed the Added column #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiled-lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"actions": "Actions",
"added": "Added",
"affectedClusters": "Affected clusters",
"all": "All",
"cancel": "Cancel",
Expand Down Expand Up @@ -45,6 +44,7 @@
"low": "Low",
"medium": "Medium",
"moderate": "Moderate",
"modified": "Modified",
"nA": "N/A",
"name": "Name",
"noAffectedClustersBody": "This recommendation does not affect any cluster.",
Expand Down
4 changes: 2 additions & 2 deletions src/AppConstants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export const RECS_LIST_COLUMNS = [
transforms: [sortable, cellWidth(40)],
},
{
title: intl.formatMessage(messages.added),
title: intl.formatMessage(messages.modified),
transforms: [sortable, cellWidth(15)],
},
{
Expand Down Expand Up @@ -277,7 +277,7 @@ export const CLUSTER_RULES_COLUMNS = [
transforms: [sortable],
},
{
title: intl.formatMessage(messages.added),
title: intl.formatMessage(messages.modified),
transforms: [sortable, cellWidth(15)],
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/Components/ClusterRules/ClusterRules.spec.ct.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { cumulativeCombinations } from '../../../cypress/utils/combine';
import { CHIP_GROUP, CHIP, ROWS } from '../../../cypress/views/filterableTable';

const EXPANDABLES = '[class="pf-c-table__expandable-row pf-m-expanded"]';
const TABLE_HEADERS = ['Description', 'Added', 'Total risk'];
const TABLE_HEADERS = ['Description', 'Modified', 'Total risk'];

const RULES_ENABLED = _.filter(data, (it) => !it.disabled).length;

Expand Down
2 changes: 1 addition & 1 deletion src/Components/RecsListTable/RecsListTable.spec.ct.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ describe('successful non-empty recommendations list table', () => {
);
});

it('sort the data by Added', () => {
it('sort the data by Modified', () => {
cy.sortByCol(1);
cy.getAllRows()
.eq(0)
Expand Down
6 changes: 3 additions & 3 deletions src/Messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ export default defineMessages({
'Clusters title used in recommendation table column and clusters tab header',
defaultMessage: 'Clusters',
},
added: {
id: 'added',
modified: {
id: 'modified',
description: 'Recommendation table column title',
defaultMessage: 'Added',
defaultMessage: 'Modified',
},
loading: {
id: 'loading',
Expand Down