fix(Cluster reports): fix infinite table re-render when there are no rules #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
force-pushed
the
ccxdev-8272-infite-re-render-clsuter-details
branch
from
603be33 to
fcae6c0
Compare
gkarat
pushed a commit
that referenced
this pull request
Jun 10, 2022
## [1.4.6](v1.4.5...v1.4.6) (2022-06-10) ### Bug Fixes * **Cluster reports:** fix infinite table re-render when there are no rules ([#315](#315)) ([54632ef](54632ef))
|
🎉 This PR is included in version 1.4.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/CCXDEV-8272.
The table, to update
filteredRows, must look at the RTQ query data, not the state variablereports. The infinite re-render was triggered by the fact that even though previous and current states hadreportsequal to an empty array, from a JS perspective, they are perceived as different objects ([] === [] ~> false).