refactor(Recommendations list): Map sorting search parameters from column names #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerreyes
approved these changes
Jul 14, 2022
…e-sort-parameter-names
gkarat
pushed a commit
that referenced
this pull request
Jul 15, 2022
## [1.5.4](v1.5.3...v1.5.4) (2022-07-15) ### Bug Fixes * **Recommendations list:** map sorting parameters from column names in the recs list table ([#359](#359)) ([9899306](9899306))
|
🎉 This PR is included in version 1.5.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
gkarat
pushed a commit
that referenced
this pull request
Aug 17, 2022
## [1.5.4](v1.5.3...v1.5.4) (2022-07-15) ### Bug Fixes * **Recommendations list:** map sorting parameters from column names in the recs list table ([#359](#359)) ([9899306](9899306))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/CCXDEV-8064.
This changes the way how Advisor builds sorting parameters in the search URL query. The name for each parameter is taken from the column name instead of using the data field name from the API response. The PR also refactors the sorting function for the recommendations list table: the algorithm is now the same as for the clusters list table, and a switch-case clause is used.