fix(redux):Fixing bug in stage #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
approved these changes
Nov 18, 2022
gkarat
pushed a commit
that referenced
this pull request
Nov 18, 2022
## [1.8.2](v1.8.1...v1.8.2) (2022-11-18) ### Bug Fixes * **Requests management:** Fix the loading bug ([#460](#460)) ([7c25856](7c25856))
|
🎉 This PR is included in version 1.8.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating redux toolkit to fix the bug in stage
The bug - for some reason when you switch between recommendations and clusters page the table stop loading and get stuck in the "isFetching"
to reproduce, open the https://console.stage.redhat.com/openshift/insights/advisor/recommendations
Go to Clusters table then back to Recommendations table
How to test this PR
0. You need both Insights Chrome and OCP Advisor locally.
Add route in Insights Chrome a to the wepback.config.js
...proxy({ env: 'stage-beta', port: 1337, appUrl: [/^\/*$/, /^\/beta\/*$/], useProxy: true, publicPath, proxyVerbose: true, isChrome: true, routes: { '/apps/ocp-advisor': { host: 'https://localhost:8004', }, }, }),run insights chrome with "npm run dev"
run this command in OCP Advisor
"BETA=true npx webpack serve --config config/dev.webpack.config.js --port=8004"
Visit the https://stage.foo.redhat.com:1337/beta/openshift/insights/advisor/recommendations then open Clusters table. After that go back to the Recommendations table