feat(OCPADVISOR-70): Enable "Upgrade Risks" tab on the cluster details view #541
Conversation
| </Provider> | ||
| </Intl> | ||
| </MemoryRouter> | ||
| <FlagProvider> |
There was a problem hiding this comment.
Maybe it's better to create a mount function like here?
https://github.com/RedHatInsights/insights-advisor-frontend/blob/7c35d4d49eb992bc7d5ba890f267788a5a9f9a11/src/SmartComponents/Recs/DetailsRules.cy.js#L17
There was a problem hiding this comment.
will do soon in a separate PR 🪄
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
==========================================
- Coverage 84.82% 84.32% -0.51%
==========================================
Files 25 27 +2
Lines 1160 1193 +33
Branches 450 458 +8
==========================================
+ Hits 984 1006 +22
- Misses 176 187 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
# [1.12.0](v1.11.2...v1.12.0) (2023-04-06) ### Features * **OCPADVISOR-70:** Enable "Upgrade Risks" tab on the cluster details view ([#541](#541)) ([c47ac72](c47ac72))
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements https://issues.redhat.com/browse/OCPADVISOR-70.
Sketched at https://www.sketch.com/s/c5c07e06-f4a1-4c64-9cdf-8b12d8ac9ad5/a/8ylYyDw.
This makes the recommendations table render in a tab on the cluster details view (/clusters/%id) and adds the second tab called "Upgrade Risks." The latter temporarily uses placeholder content.
"Upgrade Risks" tab always rendered in beta (preview) release. The tab is displayed in stable if the feature flag
ocp-advisor.upgrade-risks.enable-in-stableis set to true.I will need to refactor component tests for the Cluster component a bit so I decided not to include tests in this PR.
How to test:
Screenshots