Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Include rhc-compat subpackage #144

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

subpop
Copy link
Collaborator

@subpop subpop commented Sep 11, 2024

  • Install symlink from rhcd to yggdrasil
  • Install symlink from /etc/rhc/config.toml

Card ID: CCT-639

@subpop subpop requested a review from jirihnidek September 11, 2024 16:48
@ptoscano
Copy link
Contributor

Generally it seems OK; since this is upstream, do we want

  • a bcond in the spec file to allow disabling it?
  • build it only on certain OSes/versions? (eg on RHEL < 10, or < 9.6, or whatever)

@subpop
Copy link
Collaborator Author

subpop commented Sep 11, 2024

I wasn't sure what the best approach here is. I only put this upstream so that it could be tested faster. Under "normal" conditions, I think I would create this as a downstream-only change in dist-git rather than cluttering upstream with distribution-specific bits, but rhc is already bound to distribution specifics, so I figured upstream + sooner testing outweighed the organization aspect.

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that rhc-compat RPM package could be installed alone. Is it desired behavior?

rhc.spec.in Show resolved Hide resolved
- Install symlink from rhcd to yggdrasil
- Install symlink from /etc/rhc/config.toml
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek jirihnidek merged commit f3e6326 into RedHatInsights:main Sep 25, 2024
15 of 24 checks passed
@subpop subpop deleted the rhcd-compat branch October 1, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants