Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove the RHC Manager status from rhc client #149

Merged

Conversation

jvlcek
Copy link
Contributor

@jvlcek jvlcek commented Oct 3, 2024

Card ID: CCT-698

Remove functions showConfProfile and getConfProfile and the block of code that had invoked it.

@Lorquas
Copy link
Member

Lorquas commented Oct 3, 2024

Can one of the admins verify this patch?

Card ID: CCT-698

Remove func getConfProfile and the block of code that had invoked it.
@jvlcek jvlcek force-pushed the CCT-698_remove_RHC_manager_status branch from d244a28 to aeb6082 Compare October 3, 2024 20:03
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek jirihnidek merged commit cfdf1a8 into RedHatInsights:main Oct 4, 2024
22 checks passed
@jirihnidek
Copy link
Contributor

/packit build

jirihnidek added a commit that referenced this pull request Nov 6, 2024
* This function is not needed anymore. This function has not been
  used since #149 was merged
jirihnidek added a commit that referenced this pull request Nov 6, 2024
* This function has not been used since PR #149 was merged to
  main branch
* No need to use go-ini module
subpop pushed a commit that referenced this pull request Nov 6, 2024
* This function is not needed anymore. This function has not been
  used since #149 was merged
subpop pushed a commit that referenced this pull request Nov 6, 2024
* This function has not been used since PR #149 was merged to
  main branch
* No need to use go-ini module
@jvlcek jvlcek deleted the CCT-698_remove_RHC_manager_status branch December 9, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants