Correctly start rhc-canonical-facts.timer and service #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subpop
force-pushed
the
canonical-facts-service
branch
from
07514cd to
26fb5d6
Compare
|
/packit rebuild-failed |
subpop
force-pushed
the
canonical-facts-service
branch
from
b3d8f54 to
ee54746
Compare
subpop
force-pushed
the
canonical-facts-service
branch
3 times, most recently
from
d7ace59 to
60c40f6
Compare
Archana-PandeyM
force-pushed
the
canonical-facts-service
branch
from
60c40f6 to
2fd2cf1
Compare
subpop
force-pushed
the
canonical-facts-service
branch
7 times, most recently
from
ec67f69 to
9a1081d
Compare
subpop
force-pushed
the
canonical-facts-service
branch
5 times, most recently
from
8ca6042 to
72f554e
Compare
subpop
changed the title
jirihnidek
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks for the PR. Overall it looks good, and it seems that it works in typical scenario. I have some questions, comments and suggestions.
When starting yggdrasil service failed (due to fact that mosquitto was not running), then nothing is reported, but when I tried to run rhc disconnect and yggdrasil service was not running, then following error was printed:
root@localhost:/# rhc disconnect
Disconnecting thinkpad-p1 from Red Hat.
This might take a few seconds.
● Cannot deactivate yggdrasil service: cannot disable yggdrasil.service: cannot stop unit yggdrasil.service: timed out waiting for state 'inactive': timed out waiting 1s for unit state 'inactive'
● Disconnected from Red Hat Insights
● Disconnected from Red Hat Subscription Management
Manage your connected systems: https://red.ht/connector
The following errors were encountered during disconnect:
TYPE STEP ERROR
ERROR yggdrasil Cannot deactivate yggdrasil service: cannot disable yggdrasil.service: cannot stop unit yggdrasil.service: timed out waiting for state 'inactive': timed out waiting 1s for unit state 'inactive'
When I run rhc disconnect and then I run systemct status yggdrasil.service, then I got following warning message:
Warning: The unit file, source configuration file or drop-ins of yggdrasil.service changed on disk. Run 'systemctl daemon-reload' to reload units.
... The reason is (probably) in one of my comment.
To ensure yggd can read the facts file, create it and change ownership to yggdrasil.
The timer should only be started when `rhc connect` is run, therefore it is no longer necessary to enable the timer by default.
This package implements a basic wrapper around the systemd D-Bus API.
Running 'rhc connect' will explicitly activate and start the rhc-canonical-facts.timer unit. Likewise, running 'rhc disconnect' will explicitly deactivate and stop the rhc-canonical-facts.timer unit.
subpop
force-pushed
the
canonical-facts-service
branch
from
72f554e to
013b766
Compare
This error message seems acceptable to me. Would you prefer something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small changes to the rhc-canonical-facts service and timer. These changes are intended to ensure the timer and services run appropriately. Instead of trying to start rhc-canonical-facts.service as a requirement of yggdrasil.service, this PR changes the behavior of
roc connectso that first therhc-canonical-facts.timeris started, followed by theyggdrasil.service.Card ID: CCT-291