-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the build system to meson #162
Conversation
4f9cd97
to
fa60405
Compare
In order to build this in Fedora in accordance with the Fedora packaging guidelines (not using vendored modules), two packages need to be renamed:
These packages need to be renamed anyway, since I moved them from git.sr.ht to github.com. This PR will have to wait until those renames are complete. |
bc25dc4
to
5ba88af
Compare
41f8420
to
7190615
Compare
Builds on Fedora 39 should be expected to fail. The packages mentioned above ( |
Backported golang-github-subpop-log to Fedora 40. |
Actually, I don't think that this should wait for Fedora 40 before being ready for review. I think this PR is ready for review. |
Does it make any value to test building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do more review later today... I can see that make
is still mentioned in CONTRIBUTING.md
file. Please mention meson
in this file.
Not really, but we're currently using the packit alias of "fedora-all" to specify the distributions. We could use fedora-stable instead. |
933e338
to
e5cde66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good. I have only one question/comment.
- Remove the custom Makefile in favor of meson - Move the systemd files and other data files into a data directory - Move the srpm and spec file into a dist/srpm subdirectory
Create NVR information using forge macros
This builds on current Fedora versions only. Also include fedora-rawhide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The custom Makefile build system was leftover from when rhc was forked out of yggdrasil nearly 3 years ago. As the project evolves, the single Makefile build system is not going to scale, so it should be replaced. yggdrasil and other worker projects in the yggdrasil family use meson as the build system, so it would be beneficial to use the same in rhc.
I also bumped the version to 0.3.0.
This PR supersedes #172.
Card ID: CCT-1020