Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the build system to meson #162

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

subpop
Copy link
Collaborator

@subpop subpop commented Oct 24, 2024

The custom Makefile build system was leftover from when rhc was forked out of yggdrasil nearly 3 years ago. As the project evolves, the single Makefile build system is not going to scale, so it should be replaced. yggdrasil and other worker projects in the yggdrasil family use meson as the build system, so it would be beneficial to use the same in rhc.

I also bumped the version to 0.3.0.

This PR supersedes #172.

Card ID: CCT-1020

@subpop subpop force-pushed the port-to-meson branch 3 times, most recently from 4f9cd97 to fa60405 Compare October 24, 2024 18:07
@subpop subpop marked this pull request as draft October 25, 2024 15:35
@subpop
Copy link
Collaborator Author

subpop commented Oct 25, 2024

In order to build this in Fedora in accordance with the Fedora packaging guidelines (not using vendored modules), two packages need to be renamed:

These packages need to be renamed anyway, since I moved them from git.sr.ht to github.com. This PR will have to wait until those renames are complete.

@subpop subpop force-pushed the port-to-meson branch 2 times, most recently from bc25dc4 to 5ba88af Compare November 12, 2024 19:48
@subpop subpop force-pushed the port-to-meson branch 2 times, most recently from 41f8420 to 7190615 Compare November 25, 2024 19:43
@subpop
Copy link
Collaborator Author

subpop commented Nov 25, 2024

Builds on Fedora 39 should be expected to fail. The packages mentioned above (golang-github-subpop-log, golang-github-subpop-ini) were not back-ported to Fedora 39.

@subpop
Copy link
Collaborator Author

subpop commented Nov 25, 2024

Backported golang-github-subpop-log to Fedora 40.

@subpop subpop marked this pull request as ready for review November 26, 2024 14:56
@subpop
Copy link
Collaborator Author

subpop commented Nov 26, 2024

Actually, I don't think that this should wait for Fedora 40 before being ready for review. I think this PR is ready for review.

@subpop subpop requested a review from jirihnidek November 26, 2024 14:56
@jirihnidek
Copy link
Contributor

Does it make any value to test building rhc on all fedoras (39,40,41 ATM)?

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do more review later today... I can see that make is still mentioned in CONTRIBUTING.md file. Please mention meson in this file.

dist/srpm/rhc.spec.in Show resolved Hide resolved
@subpop
Copy link
Collaborator Author

subpop commented Nov 27, 2024

Does it make any value to test building rhc on all fedoras (39,40,41 ATM)?

Not really, but we're currently using the packit alias of "fedora-all" to specify the distributions. We could use fedora-stable instead.

@subpop subpop force-pushed the port-to-meson branch 4 times, most recently from 933e338 to e5cde66 Compare November 29, 2024 04:00
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. I have only one question/comment.

dist/srpm/rhc.spec.in Show resolved Hide resolved
- Remove the custom Makefile in favor of meson
- Move the systemd files and other data files into a data directory
- Move the srpm and spec file into a dist/srpm subdirectory
Create NVR information using forge macros
This builds on current Fedora versions only. Also include
fedora-rawhide.
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subpop subpop merged commit 2d0b921 into RedHatInsights:main Dec 2, 2024
19 of 22 checks passed
@subpop subpop deleted the port-to-meson branch December 2, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants