Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix issues of bash auto-complete script #50

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: Fix issues of bash auto-complete script #50

merged 1 commit into from
Oct 16, 2023

Conversation

jirihnidek
Copy link
Contributor

  • Card ID: RHELPLAN-164718
  • Checking of issues using shell script analysis tool shellcheck should be without any issue now.
  • Note: current version of bash auto-complete script provided by urfave package looks little bit different, but it is not compatible with rhc for some reason.

@jirihnidek jirihnidek mentioned this pull request Oct 3, 2023
Merged
@ahitacat ahitacat self-requested a review October 16, 2023 10:01
@ahitacat
Copy link
Contributor

What is the compatibility issue with the current version of bash-completion script?

@jirihnidek
Copy link
Contributor Author

What is the compatibility issue with the current version of bash-completion script?

Well, when I tried to use current version of rhc with the latest version of bash script provided by urfave go package, then it did not work and caused some errors.

If the main branch of urfave packages was used, then we would probably not see such errors. Main branch of urfave just does not play with current rhc. But I can see similar issues in the latest script provided by urfave. If I will have time I will try to create similar PR against urfave.

@jirihnidek
fix: Fix issues of bash auto-complete script
7b2be21 
* Card ID: RHELPLAN-164718
* Checking of issues using shell script analysis tool
  shellcheck should be without any issue now.
* Note: current version of bash auto-complete script provided by
  urfave package looks little bit different, but it is not
  compatible with rhc for some reason.
@jirihnidek jirihnidek force-pushed the jhnidek/fix_bash_complete_script_issues branch from 6225c21 to 7b2be21 Compare October 16, 2023 13:20
ahitacat
ahitacat approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ahitacat ahitacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ahitacat ahitacat merged commit 3593e00 into main Oct 16, 2023
@jirihnidek jirihnidek deleted the jhnidek/fix_bash_complete_script_issues branch November 7, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahitacat ahitacat ahitacat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirihnidek @ahitacat