Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csaf): use csaf evaluation by default #1133

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Aug 12, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Aug 12, 2024

Commits missing Jira IDs:
a02473f
cc2fa80
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-7871

@psegedy psegedy force-pushed the csaf_default branch 5 times, most recently from b2f1c15 to c79e4ff Compare August 12, 2024 14:31
@psegedy psegedy force-pushed the csaf_default branch 3 times, most recently from bdf857b to 271f55b Compare August 14, 2024 09:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (5a56460) to head (cc2fa80).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
vmaas-go/webapp/controllers/vulnerabilities.go 0.00% 5 Missing ⚠️
vmaas-go/webapp/controllers/utils.go 50.00% 3 Missing and 1 partial ⚠️
vmaas-go/webapp/controllers/updates.go 0.00% 3 Missing ⚠️
vmaas-go/base/core/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
- Coverage   62.98%   62.05%   -0.93%     
==========================================
  Files          70       76       +6     
  Lines        6800     6974     +174     
==========================================
+ Hits         4283     4328      +45     
- Misses       2517     2643     +126     
- Partials        0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpjrh
Copy link

fpjrh commented Aug 21, 2024

@jdobes can you provide a code review here? Thank you!

@psegedy
Copy link
Member Author

psegedy commented Sep 3, 2024

Merging without review as we need to enable csaf in stage env.
Test failure seem unrelated

schema.SchemaMissingKeyError: Missing key: 'modules_list'

@psegedy psegedy merged commit 42fd879 into RedHatInsights:master Sep 3, 2024
5 of 7 checks passed
@psegedy psegedy deleted the csaf_default branch September 3, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants