Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ephemeral): remove --no-remove-resources #1140

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Sep 4, 2024

RHINENG-11573

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Sep 4, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-11573

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.05%. Comparing base (5a56460) to head (b7b9237).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
- Coverage   62.98%   62.05%   -0.93%     
==========================================
  Files          70       76       +6     
  Lines        6800     6974     +174     
==========================================
+ Hits         4283     4328      +45     
- Misses       2517     2643     +126     
- Partials        0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy changed the title WIP: chore(ephemeral): remove --no-remove-resources chore(ephemeral): remove --no-remove-resources Sep 4, 2024
@psegedy psegedy marked this pull request as ready for review September 4, 2024 13:37
@psegedy psegedy merged commit 68e9d39 into RedHatInsights:master Sep 4, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants