Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove removed csaf files from db #1147

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Sep 24, 2024

RHINENG-12773

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Sep 24, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-12773

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.29%. Comparing base (5a56460) to head (114b6c9).
Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
vmaas/reposcan/database/csaf_store.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   62.98%   62.29%   -0.70%     
==========================================
  Files          70       76       +6     
  Lines        6800     6991     +191     
==========================================
+ Hits         4283     4355      +72     
- Misses       2517     2633     +116     
- Partials        0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy requested a review from jdobes September 24, 2024 13:57
@psegedy
Copy link
Member Author

psegedy commented Sep 24, 2024

/retest

@psegedy psegedy force-pushed the deletefile branch 2 times, most recently from 879dbe4 to 69164b5 Compare September 24, 2024 15:03
@jdobes jdobes merged commit 617fe70 into RedHatInsights:master Sep 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants