-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use black, flake8 and precommit #1395
Conversation
Referenced Jiras: |
eeec3e7
to
f157c81
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
=======================================
Coverage 67.38% 67.38%
=======================================
Files 53 53
Lines 4998 4998
=======================================
Hits 3368 3368
Misses 1630 1630
☔ View full report in Codecov by Sentry. |
f157c81
to
69045f2
Compare
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run pre-commit run --all
in gh action to force its usage and add to readme that everyone should setup pre-commit in their virtualenv. Something like:
## Setup pre-commit
cd vulnerability-engine
pipenv install --dev
pipenv shell
pre-commit install
d353293
to
5010078
Compare
d6feeb8
to
2207b18
Compare
941fdda
to
2cbd623
Compare
2cbd623
to
831fdfe
Compare
VULN-2714
VULN-2714
VULN-2714
VULN-2714
VULN-2714
VULN-2714
831fdfe
to
03719df
Compare
I left the flake8 to be less stricter than new black setup, because otherwise the pipeline would fail with many errors (length of line errors), will make flake8 strict equal to black when we run all files with black.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist