Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extend unleash feature flags #1509

Merged
merged 6 commits into from
Sep 29, 2023
Merged

fix: extend unleash feature flags #1509

merged 6 commits into from
Sep 29, 2023

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Sep 22, 2023

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Sep 22, 2023 •
edited
Loading

Commits missing Jira IDs:
25e225f
e16dd55
7ade296
bab735d
0c8b01a
ccc53a1

@psegedy psegedy force-pushed the unleashff branch 2 times, most recently from c193016 to 5263288 Compare September 22, 2023 15:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
common/utils.py 51.25% <100.00%> (+0.20%) ⬆️
manager/base.py 91.40% <ø> (-0.03%) ⬇️
manager/cve_handler.py 93.93% <100.00%> (+0.30%) ⬆️
manager/dashbar_handler.py 96.00% <100.00%> (ø)
manager/dashboard_handler.py 90.99% <100.00%> (ø)
manager/rbac_manager.py 94.60% <100.00%> (+0.02%) ⬆️
manager/report_handler.py 87.40% <100.00%> (ø)
manager/system_handler.py 98.85% <100.00%> (+0.38%) ⬆️
manager/vulnerabilities_handler.py 92.11% <100.00%> (ø)
common/feature_flags.py 65.11% <50.00%> (-0.80%) ⬇️

📢 Thoughts on this report? Let us know!.

@psegedy psegedy changed the title fix: use unleash to set up cves_without_errata feature fix: extend unleash feature flags Sep 22, 2023
@psegedy
Copy link
Member Author

psegedy commented Sep 25, 2023

/retest

@psegedy psegedy force-pushed the unleashff branch 3 times, most recently from 5cf52d4 to 0a6899d Compare September 26, 2023 12:41
@psegedy
Copy link
Member Author

psegedy commented Sep 26, 2023

/retest

1 similar comment
@psegedy
Copy link
Member Author

psegedy commented Sep 26, 2023

/retest

@psegedy psegedy force-pushed the unleashff branch 2 times, most recently from 326d02e to 4672305 Compare September 26, 2023 15:46
@psegedy
Copy link
Member Author

psegedy commented Sep 27, 2023

/retest

@psegedy
Copy link
Member Author

psegedy commented Sep 27, 2023

/retest

@psegedy
Copy link
Member Author

psegedy commented Sep 29, 2023

/retest

@jdobes jdobes added the keep-namespace Keep ephemeral env namespace after test run label Sep 29, 2023
@jdobes
Copy link
Member

jdobes commented Sep 29, 2023

/retest

@jdobes jdobes merged commit 41b7807 into RedHatInsights:master Sep 29, 2023
3 checks passed
@jdobes jdobes removed the keep-namespace Keep ephemeral env namespace after test run label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psegedy @codecov-commenter @jdobes