feat: include message id in emitted worker events #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuckBoss
force-pushed
the
jajerome/add-message-id-to-worker
branch
from
0db1a61 to
cd3f6a0
Compare
|
What is the difference between this |
subpop
requested changes
May 9, 2023
This is a signal emitted by the worker; it is not intended to be a means by which a worker can "respond" to messages. It's more like the worker saying "okay, I got the message 1234" rather than "here is message 5678 in reply to message 1234". |
DuckBoss
force-pushed
the
jajerome/add-message-id-to-worker
branch
4 times, most recently
from
825bcce to
a2b0c06
Compare
subpop
requested changes
May 19, 2023
worker/worker.go
Outdated
| func (w *Worker) EmitEvent(event ipc.WorkerEventName, message string) error { | ||
| args := []interface{}{event} | ||
| // EmitEvent emits a WorkerEvent, worker message id, and an optional message. | ||
| func (w *Worker) EmitEvent(event ipc.WorkerEventName, message string, message_id string) error { |
There was a problem hiding this comment.
Could we keep the order of arguments the same as the arguments of the D-Bus method? That reduces cognitive friction when translating between the D-Bus interface description and the implementations.
Signed-off-by: Jason Jerome <jajerome@redhat.com>
This patch also updates the "listen" yggctl action and "WorkerEvent" dbus signals to include new message ids. Signed-off-by: Jason Jerome <jajerome@redhat.com>
DuckBoss
force-pushed
the
jajerome/add-message-id-to-worker
branch
from
72aa12b to
034eb24
Compare
subpop
requested changes
May 31, 2023
Signed-off-by: Jason Jerome <jajerome@redhat.com>
subpop
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this update is to prepare for the implementation of a
message journal in yggdrasil by making small changes to workers.
This change adds the worker's message id to the emitted event data in addition
to the currently existing ipc worker event name and worker message data.
Current:
...EmitEvent(worker_event_name, worker_event_message)Proposed:
...EmitEvent(worker_event_name, worker_event_message, worker_message_id)Changes: