Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added a diagram directory #133

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ahitacat
Copy link
Contributor

@ahitacat ahitacat commented Jun 5, 2023

Added this directory to tack the protocol diagrams.

Initial diagrams added

  • Connection
  • Data message Echo worker
  • Cancel message Echo worker

Github provides a pre-view of mermaid diagrams. To see it go to the forked repo https://github.com/ahitacat/yggdrasil/tree/doc-init-diagrams/doc/diagrams

@ahitacat ahitacat force-pushed the doc-init-diagrams branch from fc5f8eb to 46034a4 Compare June 5, 2023 16:39
@ahitacat ahitacat force-pushed the doc-init-diagrams branch 3 times, most recently from af81710 to dae6b55 Compare October 24, 2023 15:31
Added this directory to tack the protocol diagrams.
Initial added:
- Connection
- Data message Echo worker
- Cancel message echo worker

Signed-off-by: Alba Hita Catala <ahitacat@redhat.com>
@ahitacat
Copy link
Contributor Author

@subpop @jirihnidek Do you think there are some diagram missing?

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek
Copy link
Contributor

I think that this PR is ready for review.

@ahitacat ahitacat marked this pull request as ready for review October 25, 2023 09:54
Copy link
Collaborator

@subpop subpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@subpop subpop merged commit e5ae5b0 into RedHatInsights:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants