fix: handle Event signals gracefully #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subpop
force-pushed
the
better-signal-handling
branch
from
99ea483 to
9d87852
Compare
jirihnidek
requested changes
Aug 14, 2023
Return errors when handling Event signals emitted by workers and handle the optional 'message' parameter gracefully. Signed-off-by: Link Dupont <link@sub-pop.net>
subpop
force-pushed
the
better-signal-handling
branch
from
9d87852 to
b48c499
Compare
|
I took a different approach towards unpacking a signal into a WorkerEvent. I dropped the two global variables; they weren't useful without adding variability to them, and after that happens, there is no reason to keep global error variables at all. I renamed the unpack error into a more descriptively named "typeConversionError", since that's more accurately describing what the error carries. I dropped the error checking for signal name and parameter length. Looping over the body slice and attempting to convert the |
jirihnidek
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return errors when handling Event signals emitted by workers and handle
the optional 'message' parameter gracefully.
Signed-off-by: Link Dupont link@sub-pop.net