Update gRPC #167
Merged
Update gRPC #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Link Dupont <link@sub-pop.net>
Signed-off-by: Link Dupont <link@sub-pop.net>
Signed-off-by: Link Dupont <link@sub-pop.net>
subpop
force-pushed
the
0.2/update-grpc
branch
from
6f51561 to
af61165
Compare
Signed-off-by: Link Dupont <link@sub-pop.net>
Signed-off-by: Link Dupont <link@sub-pop.net>
grpc.WithInsecure() is deprecated in favor of grpc.WithTransportCredentials(). Signed-off-by: Link Dupont <link@sub-pop.net>
Signed-off-by: Link Dupont <link@sub-pop.net>
|
Thanks for this @subpop ! From a high level overview the changes look good. |
adamruzicka
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gRPC versions to 1.58.3. The update to grpc 1.58.3 requires updating the minimum Go version to 1.19. Updating the Go version to 1.19 requires removing the usage of the deprecated
ioutilspackage, replacing thegolang.org/x/crypto/ssh/terminalpackage withgolang.org/x/term, and replacinggrpc.WithInsecure()withgrpc.WIthTransportCredentials(insecure.NewCredentials()). This PR includes commits that fulfill those requirements.