fix: add http env to workers execution #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahitacat
force-pushed
the
add-env-worker
branch
from
05342a2 to
290f093
Compare
jirihnidek
requested changes
Nov 13, 2023
ahitacat
force-pushed
the
add-env-worker
branch
2 times, most recently
from
53a6d87 to
5ffb207
Compare
subpop
requested changes
Nov 14, 2023
ahitacat
force-pushed
the
add-env-worker
branch
from
5ffb207 to
9e31707
Compare
Changelog
|
ahitacat
force-pushed
the
add-env-worker
branch
from
9e31707 to
2e0c3f6
Compare
subpop
requested changes
Nov 15, 2023
HACKING.md
Outdated
| Send a data message to `echo worker` | ||
| ``` | ||
| export CONSUMER_ID=$(openssl x509 -in cert.pem -subject -nocert | cut -f3 -d" ") | ||
| echo "{\"type\":\"data\",\"message_id\":\"$(uuidgen | tr -d '\n')\", \"response_to\":\" \",\"version\":1,\"sent\":\"$(date --iso-8601=seconds --utc | tr -d '\n')\",\"directive\":\"echo\",\"metadata\":\"{}\",\"content\":{\"hello world\"}}" | pub -broker tcp://test.mosquitto.org:1883 -topic yggdrasil/${CONSUMER_ID}/data/in |
There was a problem hiding this comment.
In yggdrasil-0.2, there no other mention of pub. The example "ping" above uses mosquitto_pub. I think we should stick with consistency in the documentation, even though this is the HACKING/CONTRIBUTING guide.
Suggested change
| echo "{\"type\":\"data\",\"message_id\":\"$(uuidgen | tr -d '\n')\", \"response_to\":\" \",\"version\":1,\"sent\":\"$(date --iso-8601=seconds --utc | tr -d '\n')\",\"directive\":\"echo\",\"metadata\":\"{}\",\"content\":{\"hello world\"}}" | pub -broker tcp://test.mosquitto.org:1883 -topic yggdrasil/${CONSUMER_ID}/data/in | |
| mosquitto_pub --host 127.0.0.1 --port 1883 --topic yggdrasil/${CONSUMER_ID}/data/in --message "{\"type\":\"data\",\"message_id\":\"$(uuidgen | tr -d '\n')\", \"response_to\":\" \",\"version\":1,\"sent\":\"$(date --iso-8601=seconds --utc | tr -d '\n')\",\"directive\":\"echo\",\"metadata\":\"{}\",\"content\":{\"hello world\"}}" |
There was a problem hiding this comment.
Oops sorry! Changing it.
This commit adds: yggdrasil proxy related env variable when starts the worker. How to send data messages to echo workers added in HACKING file. Signed-off-by: Alba Hita Catala <ahitacat@redhat.com>
ahitacat
force-pushed
the
add-env-worker
branch
from
2e0c3f6 to
c114022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yggdrasil adds the proxy as an env variable when starts the worker.
Resolves: CCT-112