Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Packit integration #189

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat: add Packit integration #189

merged 2 commits into from
Nov 29, 2023

Conversation

ptoscano
Copy link
Contributor

@ptoscano ptoscano commented Nov 22, 2023

Add a basic configuration for building PRs using Packit, using EL 8/9 and supported Fedora's.

The actions are needed to do the "make srpm" way manually, which is what Copr does.

Also drop the GitHub Actions for building packages manually, as Packit covers it now (and even for more distros).

@ptoscano ptoscano force-pushed the packit branch 7 times, most recently from 58f1d6a to 0a0fc26 Compare November 23, 2023 11:43
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'yggdrasil': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got [{'centos-stream-8': {'additional_repos': ['https://download.copr.fedorainfracloud.org/results/%40yggdrasil/latest/centos-stream-$releasever-x86_64/']}}, {'centos-stream-9': {'additional_repos': ['https://download.copr.fedorainfracloud.org/results/%40yggdrasil/latest/centos-stream-$releasever-x86_64/']}}, {'fedora-all': {'additional_repos': ['https://download.copr.fedorainfracloud.org/results/%40yggdrasil/latest/fedora-$releasever-x86_64/']}}, {'rhel-8': {'additional_repos': ['https://download.copr.fedorainfracloud.org/results/%40yggdrasil/latest/rhel-$releasever-x86_64/']}}, {'rhel-9': {'additional_repos': ['https://download.copr.fedorainfracloud.org/results/%40yggdrasil/latest/rhel-$releasever-x86_64/']}}] (type <class 'list'>)."]}}})}}})

For more info, please check out the documentation or contact the Packit team.

@ptoscano
Copy link
Contributor Author

/packit build

Add a basic configuration for building PRs using Packit, using EL 8/9
and supported Fedora's; also, make use of our custom Copr as base for
the content.

The actions perform a similar, although easier, steps of what is done
with "make srpm" (which is what Copr does): this way we can avoid the
package installations, and we can copy all the files needed.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Now we build using Packit, which covers more distros than our jobs.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
@ahitacat
Copy link
Contributor

/packit build

Copy link
Contributor

@ahitacat ahitacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahitacat ahitacat merged commit 315ebdc into RedHatInsights:main Nov 29, 2023
15 checks passed
@ptoscano ptoscano deleted the packit branch November 29, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants