-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Packit integration #189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoscano
force-pushed
the
packit
branch
7 times, most recently
from
November 23, 2023 11:43
58f1d6a
to
0a0fc26
Compare
Failed to load packit config file:
For more info, please check out the documentation or contact the Packit team. |
/packit build |
Add a basic configuration for building PRs using Packit, using EL 8/9 and supported Fedora's; also, make use of our custom Copr as base for the content. The actions perform a similar, although easier, steps of what is done with "make srpm" (which is what Copr does): this way we can avoid the package installations, and we can copy all the files needed. Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Now we build using Packit, which covers more distros than our jobs. Signed-off-by: Pino Toscano <ptoscano@redhat.com>
/packit build |
ahitacat
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic configuration for building PRs using Packit, using EL 8/9 and supported Fedora's.
The actions are needed to do the "make srpm" way manually, which is what Copr does.
Also drop the GitHub Actions for building packages manually, as Packit covers it now (and even for more distros).