Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist workflow #237

Merged

Conversation

subpop
Copy link
Collaborator

@subpop subpop commented May 22, 2024

With this workflow, when a new git tag is created using the semantic versioning syntax (vX.Y.Z), this workflow checkout the tag from git, generates a yggdrasil-X.Y.Z.tar.xz and attaches it as an asset to the release.

Here's an example of the workflow running on my fork.

Define an action that builds a dist tarball and attaches it to the
release.

Signed-off-by: Link Dupont <link@sub-pop.net>
@subpop subpop force-pushed the add-upload-release-asset-action branch from fdd93ca to a00881d Compare May 22, 2024 19:47
@subpop subpop requested review from jirihnidek and ptoscano May 22, 2024 19:51
@jirihnidek
Copy link
Contributor

jirihnidek commented May 23, 2024

It looks good, but given link to your fork reference following link: https://github.com/subpop/yggdrasil/releases/tag/v0.4.2, but it is not valid link. It seems that such tag (0.4.2) does not exists ATM.

@subpop
Copy link
Collaborator Author

subpop commented May 28, 2024

Oh, yea, I've been creating and deleting that tag to test the trigger conditions of the action. I didn't see a point to keeping around a release tag in my fork that isn't a real release, so I deleted it after testing.

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jirihnidek jirihnidek merged commit 5fe2d38 into RedHatInsights:main Jun 10, 2024
18 checks passed
@subpop subpop deleted the add-upload-release-asset-action branch June 10, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants