Collect workers immediately #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error being logged is not backed by another error, so it is incorrect to include 'err' in the reported error string in this situation.
DuckBoss
requested changes
Sep 2, 2024
After connecting to the bus, scan the bus names immediately for known worker names. Add a match signal to observe when worker name ownership changes.
The text format of the worker list subcommand printed worker/feature details in an arbitrary format. Since "table" already exists, "text" is redundant.
Change the table output format to print all features in a single cell. This allows workers with empty feature maps to still appear in the table output.
As of Go 1.20, it is no longer necessary to call rand.Seed with a random value.
subpop
force-pushed
the
immediate-worker-list
branch
from
dff4aa6 to
ebe1c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
yggdcould be described as "lazy discovery of workers"; a worker is only discovered when a message arrives destined for it and the message is routed. If and only ifyggdis able to successfully deliver a message to a worker, is it then added to the dispatchers table, triggering a publish of an updated "connection-status" message. This lazy-loading causesyggctlto output incorrect worker status under certain conditions. Ifyggctl workers listis run immediately after startingyggd, the list will be empty.This PR changes the procedure
yggduses to detect and collect workers. After connecting to the bus (in the(Dispatcher).Connectmethod), a goroutine is run that scans the list of names on the bus, collecting any that begin with "com.redhat.Yggdrasil1.Worker1". After the workers are found, a "connection-status" message is published.Additionally, a MatchSignal is added that watches for name ownership change (specifically the
org.freedesktop.DBus.NameOwnerChangedsignal) within the "com.redhat.Yggdrasil1.Worker1" namespace. If name ownership changes occur, the features are deleted or updated, causing a new "connection-status" message to publish.I also discovered a related bug in the table and text output formats. If a worker had an empty "features" map, the "text" and "table" would erroneously omit those workers from the output because output was based on a for-loop over the features map. I chose to drop the "text" output format entirely, since it's functionally identical to "table". I also reformatted how the features map is included in the table output.
Old
New
Fixes: #135
Card ID: CCT-115