Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add new worker nodes by using ova #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fperearodriguez
Copy link

Adding a new role to create additional worker/infra nodes using an OVA template.

About the new role:

  • The role's name is vsphere_vm_new_nodes.
  • A new playbook file has been created to execute it. The file name is new_worker_ova.yml.
  • This new playbook file uses a new cluster file that should be named _{{ clusters_folder }}/{{ cluster }}additional_nodes_ova.yaml.
  • A new section to explain the role usage has been added to the main README.
  • Additional information has been added to the cluster file to explain each parameter of this file.
  • Since this role works with infra nodes, it has been configured to label the nodes as infra or ODF (in this case, with the specific label and taint).

Fran Perea Rodriguez added 2 commits April 29, 2024 13:07
Signed-off-by: Fran Perea Rodriguez <fperea@redhat.com>
Signed-off-by: Fran Perea Rodriguez <fperea@redhat.com>
@mallmen mallmen requested a review from ddreggors June 5, 2024 17:49
@mallmen
Copy link
Member

mallmen commented Jun 5, 2024

Hey there, I apologize for not checking for PRs regularly. I apoligize again because I created a merge conflict for you by changing roles/setup/tasks/main.yml. I needed to modify the code to properly allow for building a compact cluster. Can you rebase your PR against that change?

add missing code from change submitted prior to this pr being approved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants