Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 OSIDB-3388: Remove irrelevant sorting fields #432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🔥 OSIDB-3388: Remove irrelevant sorting fields #432

wants to merge 2 commits into from
+0 −8

Conversation

C-Valen
Copy link
Collaborator

@C-Valen C-Valen commented Sep 20, 2024

OSIDB-3388 Remove irrelevant sorting fields

Checklist:

  • Commits consolidated
  • [-] Changelog updated
  • Test cases added/updated
  • [-] Jira ticket updated

Summary:

Updates new advance search to remove irrelevant sorting fields based on internal discussion.

Changes:

  • Remove cve_description and statement from new sorting options on advance search results
  • Updates snapshots

Considerations:

  • Reason considered to remove those is that being a free text fields the sorting will be random, not providing to the users a useful ordering.
  • Not reopening ticket just adding it as internal change.

@C-Valen C-Valen added the internal Skip Jira CI label Sep 20, 2024
@C-Valen C-Valen self-assigned this Sep 20, 2024
MrMarble
MrMarble approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@MrMarble MrMarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrMarble MrMarble MrMarble approved these changes

@superbuggy superbuggy Awaiting requested review from superbuggy

Assignees

@C-Valen C-Valen

Labels
internal Skip Jira CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C-Valen @MrMarble