✨ Add global Jira link #537
Open
+63
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Valen
force-pushed
the
feature/OSIDB-3964-global-jira-link
branch
from
10a441b to
4ae377e
Compare
MrMarble
reviewed
Feb 12, 2025
| @@ -175,15 +176,24 @@ const createdDate = computed(() => { | |||
| > | |||
| <div class="row osim-flaw-form-section pt-0"> | |||
| <div class="osim-flaw-form-header"> | |||
| <div v-if="flaw.meta_attr?.bz_id" class="osim-flaw-header-link"> | |||
| <div v-if="flaw.meta_attr?.bz_id || flaw.task_key" class="osim-flaw-header-link"> | |||
| <a | |||
There was a problem hiding this comment.
maybe add another v-if here, since the parent div can be displayed anyway
MrMarble
reviewed
Feb 12, 2025
| @@ -523,3 +563,6 @@ describe('flawForm', () => { | |||
| expect(wrapper.emitted()).toHaveProperty('refresh:flaw'); | |||
| }); | |||
| }); | |||
| function importOriginal(arg0: string) { | |||
superbuggy
reviewed
Feb 12, 2025
| @@ -523,3 +563,6 @@ describe('flawForm', () => { | |||
| expect(wrapper.emitted()).toHaveProperty('refresh:flaw'); | |||
| }); | |||
| }); | |||
| function importOriginal(arg0: string) { | |||
C-Valen
force-pushed
the
feature/OSIDB-3964-global-jira-link
branch
from
4ae377e to
eccf240
Compare
C-Valen
force-pushed
the
feature/OSIDB-3964-global-jira-link
branch
from
eccf240 to
726d2ab
Compare
MrMarble
approved these changes
Feb 12, 2025
superbuggy
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSIDB-3964 Add global Jira link
Checklist:
Summary:
Adds a link to Jira task if existing in the top right side of the flaw form view, just below the BZ link.
This requeriment appeared cause previously the only Jira link was on the internal comments, making it for read-only users who don't have an Jira API key set, difficult to quickly access to the related Jira task of a flaw.
Changes:
Screenshot:
Closes OSIDB-3964