Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filter by cluster prefix #156

Merged
merged 9 commits into from
Jan 30, 2025
Merged

Allow filter by cluster prefix #156

merged 9 commits into from
Jan 30, 2025

Conversation

oharan2
Copy link
Collaborator

@oharan2 oharan2 commented Jan 21, 2025

Filter resources by ocp cluster prefix.
This is important when we want to free up resources in the context of a project or any associated key value.

Can be used with env var with specifying:
export CLEANUP_AWS__CRITERIA__OCPS__OCP_PREFIX='["ocp-cluster-prefix"]'

Copy link
Collaborator

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some comments/questions

@oharan2 oharan2 requested a review from jyejare January 27, 2025 16:39
Copy link
Collaborator

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, few replies to be addressed.

@oharan2 oharan2 requested a review from jyejare January 30, 2025 09:57
@jyejare jyejare merged commit c92a058 into RedHatQE:master Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants