-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AWS CloudFormation resource deletion option #49
Conversation
There should be option to omit specified stacks - i.e. an administrator deploys a monitoring resources, but this will delete them. |
Please include 'STACKS' here also to take care of cleanup of all regions cloudwash/cloudwash/providers/ec2.py Line 13 in 8a85f38
|
Multi region cleanup should work now. |
@laDok8 Please rebase, so that we can get that in soonish !! |
dbe74f9
to
7ffe022
Compare
@jyejare found typo putting |
@laDok8 Good Catch! Do you want to raise a separate PR for it and quick. We can also improve the settings validation in that PR as well. OR I can open a quick PR for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK pending changes.
54d2d4d
to
8bfc924
Compare
@laDok8 We are very close to merge this, left some final comments ! |
@laDok8 Would you like to cut new release this week or OK for waiting for next big release including all other major changes ? |
it's ok, I'll wait |
Adding in release 1.1.0 happening on 15th Nov 2022. |
added option to delete AWS CloudFormations with
--stacks
flag