Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AWS CloudFormation resource deletion option #49

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

laDok8
Copy link
Contributor

@laDok8 laDok8 commented Sep 8, 2022

added option to delete AWS CloudFormations with --stacks flag

@istraka
Copy link

istraka commented Sep 8, 2022

There should be option to omit specified stacks - i.e. an administrator deploys a monitoring resources, but this will delete them.

@shubhamsg199
Copy link
Collaborator

shubhamsg199 commented Sep 14, 2022

Please include 'STACKS' here also to take care of cleanup of all regions

data = ['VMS', 'DISCS', 'PIPS', 'RESOURCES']

@laDok8
Copy link
Contributor Author

laDok8 commented Sep 19, 2022

Multi region cleanup should work now.

@jyejare
Copy link
Collaborator

jyejare commented Sep 26, 2022

@laDok8 Please rebase, so that we can get that in soonish !!

@laDok8 laDok8 force-pushed the add.stacks branch 3 times, most recently from dbe74f9 to 7ffe022 Compare September 29, 2022 11:47
@laDok8
Copy link
Contributor Author

laDok8 commented Sep 29, 2022

@jyejare found typo putting exception instead of exceptions breaking VM exception functionality for all cloud providers, should i split this bug fix into separate PR?

@jyejare
Copy link
Collaborator

jyejare commented Sep 30, 2022

@laDok8 Good Catch! Do you want to raise a separate PR for it and quick. We can also improve the settings validation in that PR as well. OR I can open a quick PR for it.

Copy link
Collaborator

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending changes.

settings.yaml.template Outdated Show resolved Hide resolved
cloudwash/providers/aws.py Outdated Show resolved Hide resolved
cloudwash/providers/aws.py Outdated Show resolved Hide resolved
conf/aws.yaml.template Outdated Show resolved Hide resolved
settings.yaml.template Outdated Show resolved Hide resolved
conf/azure.yaml.template Outdated Show resolved Hide resolved
settings.yaml.template Outdated Show resolved Hide resolved
cloudwash/providers/aws.py Outdated Show resolved Hide resolved
@jyejare
Copy link
Collaborator

jyejare commented Oct 4, 2022

@laDok8 We are very close to merge this, left some final comments !

@jyejare jyejare merged commit 1476c5f into RedHatQE:master Oct 4, 2022
@jyejare
Copy link
Collaborator

jyejare commented Oct 4, 2022

@laDok8 Would you like to cut new release this week or OK for waiting for next big release including all other major changes ?

@laDok8
Copy link
Contributor Author

laDok8 commented Oct 4, 2022

it's ok, I'll wait

@jyejare jyejare added this to the Release 1.1.0 milestone Oct 4, 2022
@jyejare
Copy link
Collaborator

jyejare commented Oct 4, 2022

Adding in release 1.1.0 happening on 15th Nov 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants