Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests #123

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Fixed tests #123

merged 3 commits into from
Sep 1, 2021

Conversation

LightOfHeaven1994
Copy link
Collaborator

No description provided.

@john-dupuy
Copy link
Contributor

@quarckster I bumped codecov-action to deal with codecov/codecov-action#322, we can migrate to v2 in a separate pr.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #123 (5a8edcf) into master (f999f66) will increase coverage by 4.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   85.93%   90.19%   +4.26%     
==========================================
  Files          22       22              
  Lines        1500     1499       -1     
==========================================
+ Hits         1289     1352      +63     
+ Misses        211      147      -64     
Impacted Files Coverage Δ
src/widgetastic_patternfly4/card.py 88.88% <33.33%> (ø)
src/widgetastic_patternfly4/button.py 81.13% <100.00%> (+1.50%) ⬆️
src/widgetastic_patternfly4/table.py 91.03% <100.00%> (-0.90%) ⬇️
src/widgetastic_patternfly4/dropdown.py 89.04% <0.00%> (+0.68%) ⬆️
src/widgetastic_patternfly4/ouia.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a4b368...5a8edcf. Read the comment docs.

@quarckster quarckster marked this pull request as ready for review September 1, 2021 18:48
Copy link
Contributor

@quarckster quarckster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks @LightOfHeaven1994 and @john-dupuy

@quarckster quarckster merged commit ad70ac0 into RedHatQE:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants