[1LP][RFR] replacing old openshift api with new one #255
Conversation
izapolsk
force-pushed
the
removal_old_ocp_methods
branch
from
2ff757c to
9b632a2
Compare
izapolsk
force-pushed
the
removal_old_ocp_methods
branch
2 times, most recently
from
16ea9cd to
a5eeed6
Compare
| if entity not in entities: | ||
| entities.append(entity) | ||
| return entities | ||
| namespace = namespace if namespace else self.default_namespace |
There was a problem hiding this comment.
If the user does not specify a namespace, why lock it in to default? They should specify default if they want routes from the default namespace
|
|
||
| def list_image_streams(self, namespace=None): | ||
| """Returns list of image streams""" | ||
| namespace = namespace if namespace else self.default_namespace |
| entity = Project(self, meta['name']) | ||
| entities.append(entity) | ||
| return entities | ||
| return self.o_api.list_project().items | ||
|
|
||
| def list_template(self, namespace=None): | ||
| """Returns list of templates""" | ||
| namespace = namespace if namespace else self.default_namespace |
There was a problem hiding this comment.
same comment as above. Don't lock into default namespace
| return getattr(cls, 'KIND', None) or cls.__name__ | ||
|
|
||
| @classmethod | ||
| def create(cls, provider, payload): |
There was a problem hiding this comment.
I dont see any replacement for this
There was a problem hiding this comment.
all this stuff is available thru o_api. I can add missing create_ or patch_ methods if those are really used somewhere.
There was a problem hiding this comment.
They are not used at the moment but I would like to start updating our tests to use them. Right now, we grab an object and perform various actions on it. I would like to change that to: create an object, perform actions, remove object.
There was a problem hiding this comment.
it won't be difficult to add missing methods. I'll help you.
Let me know when you decide to do that. I think we will restructure module.
izapolsk
force-pushed
the
removal_old_ocp_methods
branch
2 times, most recently
from
7e62daf to
627d725
Compare
izapolsk
changed the title
izapolsk
force-pushed
the
removal_old_ocp_methods
branch
from
627d725 to
b1a2d42
Compare
| """ | ||
| pods = self.list_pods(namespace=namespace) | ||
| containers = [] | ||
| containers.extend([pod.spec.containers for pod in pods]) |
There was a problem hiding this comment.
Instead of extending the empty list, can we just do this?
containers = [pod.spec.containers for pod in pods]
There was a problem hiding this comment.
there was more code before
| aggregate_cpu, aggregate_mem = 0, 0 | ||
| for node in self.list_node(): | ||
| aggregate_cpu += int(node.status.capacity['cpu']) | ||
| aggregate_mem += int(round(int(node.status.capacity['memory'][:-2]) * 0.00000102400)) |
There was a problem hiding this comment.
Can we have just a small comment here --
# converting KiB to GB. 1KiB = 1.024E-6 GB
bsquizz
changed the title
… wrapanapi->ocp is switched to dynamic client
izapolsk
force-pushed
the
removal_old_ocp_methods
branch
from
b1a2d42 to
cc3134a
Compare
izapolsk
changed the title
bsquizz
changed the title
|
@jawatts is working on a change to ManageIQ/integration_tests to get rid of the |
No description provided.