[RFR] make wrapanapi->openshift use latest openshift client #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izapolsk
force-pushed
the
latest_openshift_client
branch
from
03e7b77
to
470593f
Compare
izapolsk
changed the title
izapolsk
changed the title
izapolsk
force-pushed
the
latest_openshift_client
branch
from
470593f
to
e4aa9e5
Compare
mshriver
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr fixes issue when one of openshift provider instances gets incorrect auth hash during connection. It happens only when there are several different openshift providers are used.
I also tried to update openshift client to version 5.0 but it turned out that it had some issues. so, I had to roll back client upgrade. Furthermore, there is new dynamic openshift client which replaces current generated client. So, it doesn't make sense to migrate to intermediate version.