Remove all unused Disks, PIPs and NICs from a resource group #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mshriver merged 1 commit into RedHatQE:master from jyejare:azure_cleanup

Apr 23, 2021

Contributor

jyejare commented Mar 17, 2021 •

edited

Loading

Closes #444 .

Additionaly, this PR adds a single function to remove all unused resources called cleanup_resources().

Contributor Author

jyejare commented Mar 17, 2021

Test Results:

In[6]: asys.cleanup_resources()
Out[6]: True

Contributor Author

jyejare commented Mar 22, 2021

Need a review here please !

mshriver added the Azure label

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

jyejare force-pushed the azure_cleanup branch from 828243b to 2c5785b Compare

April 1, 2021 14:30

Contributor Author

jyejare commented Apr 3, 2021

@mshriver Everything works perfect post changes:

> asys
<wrapanapi.systems.msazure.AzureSystem object at 0x10c141040>
> asys.list_free_nics()
['gqfzadzwnl-nic0', 'hoogczhxgw-nic0', 'hqwklatgvu-nic0', 'jbwdicmdrm-nic0', 'mpnlmjpeup-nic0', 'sflfbcmxis-nic0', 'trtafbseei-nic0']
> asys.list_free_discs()
['gqfzadzwnl-osdisk', 'hoogczhxgw-osdisk', 'hqwklatgvu-osdisk', 'jbwdicmdrm-osdisk', 'mpnlmjpeup-osdisk', 'sflfbcmxis-osdisk', 'trtafbseei-osdisk']
> asys.list_free_pip()
['gqfzadzwnl-pip0', 'hoogczhxgw-pip0', 'hqwklatgvu-pip0', 'jbwdicmdrm-pip0', 'mpnlmjpeup-pip0', 'sflfbcmxis-pip0', 'trtafbseei-pip0']
> asys.cleanup_resources()
True
> asys.list_free_nics()
[]
> asys.list_free_discs()
[]
> asys.list_free_nics()
[]

jyejare force-pushed the azure_cleanup branch 2 times, most recently from 950554d to 0dcabc9 Compare

April 14, 2021 09:08

Contributor Author

jyejare commented Apr 14, 2021

@mshriver Addressed your comments we discussed in GChat !

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Show resolved Hide resolved

mshriver requested changes

View reviewed changes

Collaborator

mshriver left a comment

Couple more changes, looking solid now though.

jyejare force-pushed the azure_cleanup branch from 0dcabc9 to 209163f Compare

April 16, 2021 11:53

mshriver reviewed

View reviewed changes

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved


          Remove all unused Disks, PIPs and NICs from a resource group

fe93efd

jyejare force-pushed the azure_cleanup branch from 209163f to fe93efd Compare

April 16, 2021 12:06

Contributor Author

jyejare commented Apr 16, 2021

@mshriver All latest comments are addressed!

mshriver approved these changes

View reviewed changes

mshriver merged commit c8524ff into RedHatQE:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels