Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin the boto from setup.cfg #451

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

omkarkhatavkar
Copy link
Contributor

@omkarkhatavkar omkarkhatavkar commented Feb 23, 2022

>>> from wrapanapi import EC2System
>>> client = wrapanapi.EC2System(username='username', password='password', region='us-west-2')
>>> client.create_vm('ami-0686851c4e7b1a8e1')
<wrapanapi.systems.ec2.EC2Instance system=<EC2System> raw=<boto3.resources.factory.ec2.Instance>, kwargs['uuid']='i-uuid'>

>>> client.list_vms()
[<wrapanapi.systems.ec2.EC2Instance system=<EC2System> raw=<boto3.resources.factory.ec2.Instance>, kwargs['uuid']='i-uuid'>]

Copy link
Collaborator

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a change we need to make for wrapanapi to stay recent with AWS.

There is some risk involved here if we hit breaking changes, but looking through the changelog from 1.10.50 to 1.21.5 the maintainers of boto3 have not made any breaking changes in all of that time. Only updating AWS clients and bug fixes.

@mshriver mshriver merged commit 1a0ee5b into RedHatQE:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants