Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete whole azure group #453

Merged
merged 1 commit into from
Jun 30, 2022
Merged

delete whole azure group #453

merged 1 commit into from
Jun 30, 2022

Conversation

laDok8
Copy link
Contributor

@laDok8 laDok8 commented May 4, 2022 •
edited
Loading

added option to delete whole group if all resources are older than hours_old. deleting individual resources would be difficult due to inability to delete dependent resources.

@laDok8 laDok8 mentioned this pull request May 4, 2022
Merged
@mnovak1
Copy link

mnovak1 commented May 19, 2022

@mshriver Hi, could you take a look at thie MR, please?

jyejare
jyejare requested changes May 19, 2022
View reviewed changes
Copy link
Contributor

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending comments!

wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved
wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved
wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved
wrapanapi/systems/msazure.py Outdated Show resolved Hide resolved
jyejare
jyejare approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with nitpick comment !

@jyejare
Copy link
Contributor

jyejare commented Jun 20, 2022

@mshriver Could you merge this ? As I dont have access to merge.

@jyejare
Copy link
Contributor

jyejare commented Jun 30, 2022

Ping @laDok8 and @mshriver ! Can we get this in if we are done with this ?

The dependent PR for this in cloudwash has already been merged / accedently! Can we resolve non blocking comments in followup PR please.

@laDok8
Copy link
Contributor Author

laDok8 commented Jun 30, 2022

sorry for that, i have bad habit of not marking comments resolved as i wrongly expect other side to do so ... @mshriver all current remarks should be solved.

@mshriver mshriver merged commit 6076cbb into RedHatQE:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshriver mshriver mshriver approved these changes

@jyejare jyejare jyejare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laDok8 @mnovak1 @jyejare @mshriver