add support for chrome 99+ #70
Conversation
`port.sender.url` contains `//devtools`
|
Just wanted to confirm: I build/installed this change locally and it does indeed fix the issue. Thanks! |
|
Works for me two, please merge |
|
It works good for me in v99 of chrome. |
|
the pr version works for me in v100.0.4896.60 of chrome, macos |
|
This works on my macos with chrome 100.0.4896.88 (x86_64). The production chrome plugin is still broken without this PR. |
|
This fix didn't work for me on ubuntu 22.04. Used firefox at the mean time. |
|
Works for me on Mac/Chrome 100, but not on Ubuntu 22/Chrome 100. |
|
Nice 👍 |
|
Are there any plans to merge this PR? |
Not that I know of. This repository appears to be abandoned (last commit in June 2021). If you like to, you can build extension locally or even just open the |
|
Relevant Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1364293 |
| @@ -1,7 +1,7 @@ | |||
| const toolsPorts = new Map() | |||
|
|
|||
| chrome.runtime.onConnect.addListener(port => { | |||
| if (port.sender.url == chrome.runtime.getURL('/devtools/panel.html')) { | |||
| if (port.sender.url.replace('//devtools', '/devtools') == chrome.runtime.getURL('/devtools/panel.html')) { | |||
There was a problem hiding this comment.
More universal solution:
| if (port.sender.url.replace('//devtools', '/devtools') == chrome.runtime.getURL('/devtools/panel.html')) { | |
| if (port.sender.url.replaceAll('//', '/') == chrome.runtime.getURL('/devtools/panel.html')) { |
And what do you think about adding toLowerCase()?
|
The Chromium DevTools bug (linked above) was fixed and fix was already rolled into Chromium. I tested on Chromium Version 108.0.5358.0 (Developer Build) (64-bit) and |
|
I just checked on Google Chrome Beta 108 and Svelte Devtools worked fine. If you still would like to use this extension, you can just install Chrome Beta or wait until November 29 for Chrome 108 to be released officially. Test details:
|
fix: #69