Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to manifest v3 #137

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat: migrate to manifest v3 #137

merged 1 commit into from
Sep 14, 2023

Conversation

ignatiusmb
Copy link
Member

@ignatiusmb ignatiusmb commented Sep 13, 2023

Extracted from #133

The Chrome Web Store no longer accepts Manifest V2 as stated from https://developer.chrome.com/docs/extensions/mv2/, this PR goes through the migration checklist and converts the extension to use V3 APIs.

Compatibility with Firefox is a bit tricky but doable, according to https://stackoverflow.com/a/75203925

  • Chrome is not happy with background.scripts and insists on using background.service_worker
  • Firefox doesn't support background.service_worker and wants background.scripts

Before publishing to Firefox, we'll just need to replace "service_worker": "background.js" with "scripts": ["background.js"]. I've tested the extension locally on Firefox by loading it as a temporary extension and it happily accepts the .zip file.

However, I'm getting "Missing host permission for the tab" error on Firefox, which doesn't seem to happen with Chromium based browsers. This will need to be investigated further later on, we may need to change or add upon the "activeTab" permissions with "tabs", but that would trigger a warning message during installation.


Closes #68 - kit works out of the box
Closes #69 - should work but upgrade to svelte 4
Closes #72 - kit works without additional configuration
Closes #73 - should work with all chromium browsers
Closes #76 - should not be a problem now

Also,
Closes #70

@ignatiusmb ignatiusmb marked this pull request as draft September 13, 2023 07:07
@ignatiusmb ignatiusmb marked this pull request as ready for review September 14, 2023 09:42
@ignatiusmb ignatiusmb merged commit 1241e69 into master Sep 14, 2023
1 check passed
@ignatiusmb ignatiusmb deleted the manifest-v3 branch September 14, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment