Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix translations on quilt and some updates #97

Merged

Conversation

tildejustin
Copy link
Contributor

@tildejustin tildejustin commented Dec 26, 2023

this can wait until after 14.1

Merge base version

  • MC Version: 1.16.1
  • SpeedRunIGT Version: ~14.1

Changes:

  • moved translations to proper directory (does this break automation?)
  • optimize translation implementation, fixing quilt as well
  • change linux dir from ~/.speedrunigt to ~/.config/speedrunigt (addition to use ~/.speedrunigt on linux #93, should be released together)
  • updated gradle to 8.5 and regenerated wrapper (can be reverted, I just don't like using outdated tools)
  • updated loom and mappings
  • switched to using built in property substitution for target version
  • fixed min loader dep to 0.14.20 reflect reality (bumped target to 0.24.25 to avoid having mixinextras at compiletime)

@tildejustin tildejustin changed the title Fix/better translations and misc fix translations on quilt and some updates Dec 26, 2023
@DuncanRuns
Copy link
Contributor

DuncanRuns commented Dec 28, 2023

Lots of files changed here and I have some more changes I want to make for 14.1 so we may see some conflicts

@tildejustin
Copy link
Contributor Author

i'll rebase when you're done

@tildejustin tildejustin force-pushed the fix/better-translations-and-misc branch from 363908e to ce84691 Compare January 8, 2024 20:49
@tildejustin
Copy link
Contributor Author

i have split this commit up into cherrypickable and not cherrypickable commits in order to aid in backporting, and reduced the scale a bit.

@tildejustin
Copy link
Contributor Author

tildejustin commented Jan 8, 2024

the ~/speedrunigt/ -> ~/.speedrunigt/ -> ~/.config/speedrunigt/ pr will be reverted for the release of 14.1, and i will merge #93 with 513fe09 in a new pr to be merged around when the event system is being backported

@RedLime RedLime merged commit 6c4dd91 into RedLime:1.16.1 Jan 9, 2024
@tildejustin tildejustin deleted the fix/better-translations-and-misc branch January 9, 2024 01:04
tildejustin added a commit to tildejustin/speedrunigt that referenced this pull request Feb 19, 2024
* update fabric loader dependency and target version

* update mappings

* optimize translation loading impl (fixes quilt incompatibility)

* move translation files to their proper location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants