Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix filter for light/dark modes #218

Open
fedulvtubudul opened this issue Sep 15, 2023 · 1 comment
Open

Add prefix filter for light/dark modes #218

fedulvtubudul opened this issue Sep 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@fedulvtubudul
Copy link

fedulvtubudul commented Sep 15, 2023

Our designer uses variable modes for light and dark modes. Nope, actually we have both variable modes AND color styles, and it seems to be irrelevant to this exact proposal.

figma-export sees these colours like this (breakpoint inside loadColorsFromSingleFile method):

(lldb) print colors.map({ $0.name }).sorted()
([String]) $R1 = 66 values {
  [0] = "dark-theme/accent-01"
  [1] = "dark-theme/accent-02"
  [2] = "dark-theme/accent-03"
...
  [33] = "light-theme/accent-01"
  [34] = "light-theme/accent-02"
  [35] = "light-theme/accent-03"
...

So I assume adding a new parameter so that we can filter resources not only by suffix, but by prefix as well.

@fedulvtubudul fedulvtubudul changed the title Add variable modes support Add suffix filter for light/dark modes Sep 15, 2023
@fedulvtubudul fedulvtubudul changed the title Add suffix filter for light/dark modes Add prefix filter for light/dark modes Sep 15, 2023
@subdan subdan added the enhancement New feature or request label Sep 16, 2023
fedulvtubudul added a commit to fedulvtubudul/figma-export that referenced this issue Mar 28, 2024
@fedulvtubudul
Copy link
Author

@subdan please check the PR #235 i've done regarding this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants