AND-147: add EventQueue and rename to ViewModelEvents #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmogurovAnton
commented
Jul 24, 2024
osipxd
reviewed
Jul 29, 2024
osipxd
reviewed
Jul 29, 2024
AleksandrTabolin
approved these changes
Jul 30, 2024
osipxd
reviewed
Jul 30, 2024
| - [Installation](#installation) | ||
| - [Usage](#usage) | ||
| - [`LiveData` delegate](#livedata-delegate) | ||
| - [Events Queue](#events-queue) | ||
| - [ViewModelEvents](#viewmodelevents) |
There was a problem hiding this comment.
I think ViewModelEvents should be removed from this README. It would be great to add a note about this removal to the changelog of lifecycle-livedata-ktx
|
|
||
| *No changes* | ||
|
|
||
| ## 1.0.0 - 2024.05.14 |
There was a problem hiding this comment.
Can you remove the date for now? We'll add the actual release date later
Comment on lines
+2
to
+3
| [][mavenCentral] | ||
| [][license] |
There was a problem hiding this comment.
Suggested change
| [][mavenCentral] | |
| [][license] | |
| [][mavenCentral] | |
| [][license] |
| @@ -0,0 +1,194 @@ | |||
| # ViewModelEvents <GitHub path="RedMadRobot/gears-android/tree/main/ktx/viewmodel-events-ktx"/> | |||
There was a problem hiding this comment.
This tag is not needed anymore. It was previously required for rendering in our knowledge base
Suggested change
| # ViewModelEvents <GitHub path="RedMadRobot/gears-android/tree/main/ktx/viewmodel-events-ktx"/> | |
| # ViewModelEvents |
osipxd
reviewed
Jul 30, 2024
| Merge requests are welcome. | ||
| For major changes, please open an issue first to discuss what you would like to change. | ||
|
|
||
| [mavenCentral]: https://search.maven.org/artifact/com.redmadrobot.eventqueue/eventqueue-livedata |
There was a problem hiding this comment.
[mavenCentral]: https://central.sonatype.com/artifact/com.redmadrobot.viewmodelevents/viewmodelevents-common| @@ -33,6 +33,12 @@ Gears could be used together or alone. | |||
| - [][resources-ktx] - A set of extensions for accessing resources | |||
| - [][viewbinding-ktx] - A set of extensions for dealing with ViewBinding | |||
|
|
|||
| ### :mag_right: **[ViewModelEvents](viewmodelevents/)** | |||
There was a problem hiding this comment.
Maybe better to use 💬 :speech_balloon: here?
There was a problem hiding this comment.
I think we could, but would it be better to leave it for TextValue?
There was a problem hiding this comment.
Otherwise i don't have any ideas which emoji we should use there :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.