Fix missing dockerfile syntax #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasjulian
changed the title
|
Just want to see if @netanelravid can confirm this works for him? |
|
I'll check and update (on vacation, should be near my laptop in 24h more or less) |
|
Sounds good @netanelravid, try to relax :) and thanks for your help! If you say it looks good, I'll merge it |
|
Just checked it, looks great, you can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Yesterday i try to setup eyewitness with Dockerfile but unfortunately fail.
So I'm just make litle bit change in Dockerfile and everything run pretty fine.
And i want to share my change, maybe it can help others.
Thank you