This repository has been archived by the owner on Nov 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
chore: data element insertion - lighthouse id - block listing #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ImageTemplate refactored
Bundle size diff
|
SaraBianchi
reviewed
Nov 7, 2022
src/components/ItaliaTheme/Blocks/Listing/CompleteBlockLinksTemplate.jsx
Outdated
Show resolved
Hide resolved
SaraBianchi
reviewed
Nov 7, 2022
Questa PR secondo me andava nei FEAT non nei CHORE |
SaraBianchi
approved these changes
Nov 7, 2022
Corretto. Quando la si mergia, fare "Squash and merge" e personalizzare il messaggio del commit risultante mettendo "feat: ". Se non è chiaro lo facciamo assieme. |
pnicolli
suggested changes
Nov 7, 2022
Comment on lines
52
to
67
service_category_link: { | ||
id: 'service-category-link', | ||
defaultMessage: 'service-category-link', | ||
}, | ||
topic_element: { | ||
id: 'topic-element', | ||
defaultMessage: 'topic-element', | ||
}, | ||
service_link: { | ||
id: 'service-link', | ||
defaultMessage: 'service-link', | ||
}, | ||
administration_element: { | ||
id: 'administration-element', | ||
defaultMessage: 'administration-element', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Penso che non serva che questi id siano traducibili in altre lingue, giusto? In tal caso semplificherei togliendo questi e togliendo sotto i vari intl.formatmessage()
corrispondenti
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Us#34658
Nella sidebar dei blocchi elenco, è stato aggiunto un campo in cui si può scrivere scegliere un ID. Tale ID deve essere applicato dal personale RT come valore del data-element sul link delle card su blocchi elenco:
Il campo aggiunto è un select con: