-
Notifications
You must be signed in to change notification settings - Fork 5
btcaddress.txt #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @waqar1214 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| 34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo | ||
| bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97 | ||
| 3M219KR5vEneNb47ewrPfWyb5jQ2DjxRP6 | ||
| bc1ql49ydapnjafl5t2cp9zqpjwe6pdgmxy98859v2 | ||
| bc1qazcm763858nkj2dj986etajv6wquslv8uxwczt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider adding explanatory comments for different address types
Adding brief comments or headers to explain the different Bitcoin address formats (legacy, Bech32) could improve readability and educational value.
# Legacy (P2PKH) addresses
34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo
3M219KR5vEneNb47ewrPfWyb5jQ2DjxRP6
# Bech32 (P2WPKH) addresses
bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97
bc1ql49ydapnjafl5t2cp9zqpjwe6pdgmxy98859v2
bc1qazcm763858nkj2dj986etajv6wquslv8uxwczt
| 3M219KR5vEneNb47ewrPfWyb5jQ2DjxRP6 | ||
| bc1ql49ydapnjafl5t2cp9zqpjwe6pdgmxy98859v2 | ||
| bc1qazcm763858nkj2dj986etajv6wquslv8uxwczt | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (documentation): Empty line at the end of the file
While often good practice, verify if this empty line serves a specific purpose in this context.
| @@ -0,0 +1,6 @@ | |||
| 34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is really
| @@ -0,0 +1,6 @@ | |||
| 34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo | |||
| bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most common
| @@ -0,0 +1,6 @@ | |||
| 34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo | |||
| bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97 | |||
| 3M219KR5vEneNb47ewrPfWyb5jQ2DjxRP6 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going back to work
| 34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo | ||
| bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97 | ||
| 3M219KR5vEneNb47ewrPfWyb5jQ2DjxRP6 | ||
| bc1ql49ydapnjafl5t2cp9zqpjwe6pdgmxy98859v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first time we saw the first one
| bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97 | ||
| 3M219KR5vEneNb47ewrPfWyb5jQ2DjxRP6 | ||
| bc1ql49ydapnjafl5t2cp9zqpjwe6pdgmxy98859v2 | ||
| bc1qazcm763858nkj2dj986etajv6wquslv8uxwczt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo
bc1qgdjqv0av3q56jvd82tkdjpy7gdp9ut8tlqmgrpmv24sq90ecnvqqjwvw97
3M219KR5vEneNb47ewrPfWyb5jQ2DjxRP6
bc1ql49ydapnjafl5t2cp9zqpjwe6pdgmxy98859v2
bc1qazcm763858nkj2dj986etajv6wquslv8uxwczt