[8.2] [MOD-10681] Fix cursor list empty#6601
Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.2from Aug 6, 2025
Merged
[8.2] [MOD-10681] Fix cursor list empty#6601redisearch-backport-pull-request[bot] merged 1 commit into8.2from
redisearch-backport-pull-request[bot] merged 1 commit into8.2from
Conversation
* fix cursorList_Empty to mark delete instead of instant delete * remove redundant GC call * remove unused destroy * remove Destroy from h file * update owernship test * fix comments * expand test to multiple cursors * fix loop * use std::vector and std::find (cherry picked from commit 188a741)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.2 #6601 +/- ##
==========================================
- Coverage 89.44% 89.38% -0.06%
==========================================
Files 252 252
Lines 41557 41553 -4
Branches 3666 3666
==========================================
- Hits 37170 37144 -26
- Misses 4338 4360 +22
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lerman25
approved these changes
Aug 6, 2025
alonre24
added a commit
to alonre24/redis
that referenced
this pull request
Aug 12, 2025
* Protect cursors that are running in the background for FT.AGGREGATE command while running FLUSHDB and avoid server crash - RediSearch/RediSearch#6601 * Fix performance regression in `info` command upon computing search indexes memory due to a change in Trie data structure implementation, and having it in O(1) again - RediSearch/RediSearch#6621
YaacovHazan
pushed a commit
to redis/redis
that referenced
this pull request
Aug 13, 2025
* Protect cursors that are running in the background for FT.AGGREGATE command while running FLUSHDB and avoid server crash - RediSearch/RediSearch#6601 * Fix performance regression in `info` command upon computing search indexes memory due to a change in Trie data structure implementation, and having it in O(1) again - RediSearch/RediSearch#6621
YaacovHazan
pushed a commit
to redis/redis
that referenced
this pull request
Aug 13, 2025
* Protect cursors that are running in the background for FT.AGGREGATE command while running FLUSHDB and avoid server crash - RediSearch/RediSearch#6601 * Fix performance regression in `info` command upon computing search indexes memory due to a change in Trie data structure implementation, and having it in O(1) again - RediSearch/RediSearch#6621
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6594 to
8.2.