Support Vector Similarity #151
Conversation
Avital-Fine
requested review from
filipecosta90,
chayim and
DvirDukhan
and removed request for
filipecosta90
| } | ||
|
|
||
| if q.Dialect != 0 { | ||
| args = args.Add("DIALECT", q.Dialect) |
There was a problem hiding this comment.
Any reason to not add dialect anyways?
There was a problem hiding this comment.
I saw that Jedis didn't
|
@Avital-Fine the code looks right, but did you notice the CI failure? I think it's because we're using redisearch:1.6.15 and you probably want a more modern docker (redis-stack-server or redismod) |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
How do I update the docker then? |
Update test skip version
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 76.44% 76.86% +0.41%
==========================================
Files 13 13
Lines 1346 1383 +37
==========================================
+ Hits 1029 1063 +34
- Misses 259 261 +2
- Partials 58 59 +1
Continue to review full report at Codecov.
|
closes #146