Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keep_docs to drop_index #108

Merged
merged 7 commits into from
Feb 21, 2021
Merged

add keep_docs to drop_index #108

merged 7 commits into from
Feb 21, 2021

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Dec 20, 2020

fix #107

We should decide on a default behavior of removal of documents.

  • Remove - like FT.DROP
  • Keep - like FT.DROPINDEX

@codecov
Copy link

codecov bot commented Dec 20, 2020 •
edited
Loading

Codecov Report

Merging #108 (2a41366) into master (f07c09b) will decrease coverage by 0.00%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.01%     
==========================================
  Files          12       12              
  Lines        1656     1675      +19     
==========================================
+ Hits         1491     1508      +17     
- Misses        165      167       +2
Impacted Files Coverage Δ
redisearch/client.py 85.62% <66.66%> (-0.44%) ⬇️
test/test.py 95.88% <94.11%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07c09b...2a41366. Read the comment docs.

@ashtul ashtul mentioned this pull request Dec 20, 2020
Closed
rafie
rafie reviewed Dec 20, 2020
View reviewed changes
rafie
rafie reviewed Dec 20, 2020
View reviewed changes
@ashtul
Copy link
Contributor Author

ashtul commented Dec 21, 2020

@emmanuelkeller
Signature for drop_index now has param delete_documents=True.

@ashtul ashtul requested review from rafie and removed request for MeirShpilraien December 22, 2020 07:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

emmanuelkeller
emmanuelkeller approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@emmanuelkeller emmanuelkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmanuelkeller emmanuelkeller mentioned this pull request Feb 19, 2021
Closed
@ashtul ashtul merged commit f3f11a4 into master Feb 21, 2021
@gkorland gkorland deleted the Add-keepDocs-option-to-drop_index branch April 23, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafie rafie rafie approved these changes

@emmanuelkeller emmanuelkeller emmanuelkeller approved these changes

@K-Jo K-Jo Awaiting requested review from K-Jo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent index drop behavior
3 participants
@ashtul @rafie @emmanuelkeller